fix: allows importing TS files with .js extension#417
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables importing TypeScript files using .js extensions by default in Rstest environments. The change addresses a limitation where Rsbuild only allows .js extension imports for TypeScript files when a tsconfig.path file exists, which may not be present in Rstest workspace root directories.
- Adds
extensionAliasconfiguration to resolve.jsimports to.js,.ts, and.tsxfiles - Adds
extensionAliasconfiguration to resolve.jsximports to.jsxand.tsxfiles - Updates test snapshots to reflect the new resolve configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/core/plugins/basic.ts | Implements the extensionAlias configuration for TypeScript file resolution |
| packages/core/tests/core/snapshots/rsbuild.test.ts.snap | Updates test snapshots to include the new extensionAlias configuration |
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allows importing TS files with
.jsextension by default.Rsbuild allows importing TypeScript files with the
.jsextension when atsconfig.pathfile exists. However, in the Rstest scenario, the workspace root directory may not have atsconfig.path.Related Links
https://github.com/web-infra-dev/rsbuild/blob/4fa7e847ec66f6f0c5f5518e46185ee69ad0b819/packages/core/src/plugins/resolve.ts#L132
Checklist