Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes worker pool creation by dynamically adjusting the number of workers based on the actual number of tests to run, avoiding the creation of unused workers when running fewer tests than the default thread count. This provides significant performance improvements for single test file execution.
- Introduces dynamic worker count calculation based on test entries and command type
- Modifies worker pool configuration to use the recommended count instead of static thread count
- Maintains full thread utilization for watch mode while optimizing for single runs
Comments suppressed due to low confidence (1)
packages/core/src/pool/index.ts:85
- [nitpick] The variable name 'recommendCount' is grammatically awkward. Consider renaming to 'recommendedCount' or 'optimalWorkerCount' for better clarity.
const recommendCount =
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid creating unused workers when the number of tests is less than the default thread count.
This significantly improves performance when running a single test file.
before:
after:
Related Links
Checklist