feat: add istanbul coverage provider#399
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
packages/core/package.json
Outdated
| "istanbul-reports": "^3.1.7", | ||
| "pathe": "^2.0.3", | ||
| "std-env": "^3.9.0", | ||
| "swc-plugin-coverage-instrument": "^0.0.28", |
There was a problem hiding this comment.
Builtin istanbul coverage directly into Rstest is too heavy. Rstest can provide a separate package for users to install as needed. When users set provider: 'istanbul', rstest can import the relevant transform plugin and provider from @rstest/coverage-istanbul.
packages/core/src/core/rsbuild.ts
Outdated
| }; | ||
|
|
||
| if (coverage?.enabled && coverage?.provider === 'istanbul') { | ||
| const swcPluginCoverageInstrument = `${process.cwd()}/node_modules/@rstest/coverage-istanbul/node_modules/swc-plugin-coverage-instrument/target/wasm32-wasip1/release/swc_plugin_coverage.wasm`; |
There was a problem hiding this comment.
This path should be imported from @rstest/coverage-istanbul rather than hard-coded in rstset.
And target/wasm32-wasip1/release/swc_plugin_coverage.wasm is the default export of swc-plugin-coverage-instrument
packages/core/src/core/rsbuild.ts
Outdated
| config.module.rules ??= []; | ||
| config.module.rules.push({ | ||
| test: /\.(js|ts)$/, | ||
| exclude: [/node_modules/], |
There was a problem hiding this comment.
some test files should be excluded.
packages/core/src/coverage/index.ts
Outdated
| @@ -0,0 +1,23 @@ | |||
| import type { CoverageOptions } from '../types/coverage'; | |||
| import type { CoverageProvider } from './istanbul'; | |||
| import { IstanbulCoverageProvider } from './istanbul'; | |||
There was a problem hiding this comment.
IstanbulCoverageProvider should also extract to @rstest/coverage-istanbul
Summary
add istanbul coverage provider.
Related Links
#398
Checklist