Skip to content

test: simplify browser e2e headless setup#1028

Merged
9aoy merged 5 commits intomainfrom
test/simplify-browser-e2e-headless-defaults
Mar 10, 2026
Merged

test: simplify browser e2e headless setup#1028
9aoy merged 5 commits intomainfrom
test/simplify-browser-e2e-headless-defaults

Conversation

@fi3ework
Copy link
Copy Markdown
Member

@fi3ework fi3ework commented Mar 9, 2026

Summary

  • Remove --browser.headless CLI flags from all scripts — headless behavior is already controlled per-fixture
  • Add missing headless: true to the two multi-project-config fixtures that were omitted
  • Gate the three headed-only smoke tests behind CI || RSTEST_E2E_RUN_HEADED so they are skipped locally by default
  • Remove the intermediate BROWSER_HEADLESS env var chain from e2e config/helpers
  • Remove examples/browser-projects — the existing multi-project-config e2e fixture already covers this scenario
  • Move example tests out of the root rstest.config.mts projects into an explicit test:examples CI step
  • Document RSTEST_E2E_RUN_HEADED in contributor and agent docs

Background

The browser.headless default is isCI (via std-env). However, the e2e child processes explicitly clear CI and GITHUB_ACTIONS via defaultEnvOverrides, so isCI is always false inside fixtures — making explicit headless: true in each fixture config essential.

The previous --browser.headless flags in package scripts were therefore redundant. Two fixtures were missing headless: true and are now fixed. Removing the flags keeps the mechanism in one place and avoids confusion.

Opt-in to headed tests locally

RSTEST_E2E_RUN_HEADED=true pnpm e2e

fi3ework added 4 commits March 9, 2026 19:55
…ncy=1

The multi-project browser config scenario is already covered by the
e2e/browser-mode/multi-project-config fixture. With browser-projects
removed, the only remaining browser example is browser-react, so
the port conflict that required serial execution is gone.
@fi3ework fi3ework changed the title test: simplify browser e2e headless defaults test: simplify browser e2e headless defaults and skip no-isolate on Node 20 Mar 10, 2026
@fi3ework fi3ework changed the title test: simplify browser e2e headless defaults and skip no-isolate on Node 20 test: simplify browser e2e headless setup Mar 10, 2026
@fi3ework fi3ework requested a review from 9aoy March 10, 2026 03:43
@9aoy 9aoy enabled auto-merge (squash) March 10, 2026 04:11
@9aoy 9aoy merged commit 876997c into main Mar 10, 2026
9 checks passed
@9aoy 9aoy deleted the test/simplify-browser-e2e-headless-defaults branch March 10, 2026 04:26
@9aoy 9aoy mentioned this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants