Conversation
313f835 to
0546dd5
Compare
7a905de to
83027d9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2E Test (No Isolate)on Node 20 in the e2e matrixvmnative crashesWhy
We traced the flaky
No Isolatefailures down to native worker crashes on Node 20 in CI, rather than normal JavaScript test failures. The crash only reproduced in the reused-worker no-isolate path, and newer Node versions are not currently showing the same issue.Skipping this matrix entry keeps the rest of the Node 20 e2e coverage while removing the flaky path from CI.
Details
No Isolatecoverage on newer Node versions.github/workflows/test.yml