fix(browser): serialize headed file execution#1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Headed browser test execution previously ran all test files in parallel by
firing reloads concurrently and waiting on a single shared "all tests done"
promise. This PR replaces that approach with a
HeadedSerialTaskQueuethatruns one file at a time, waits for iframe frames to be ready before starting,
and applies a per-file timeout instead of a single global timeout.
Behavior diff:
Changes:
headedSerialTaskQueue.ts— new module; serial promise queue that keepsdraining on individual task failures
hostController.ts—waitForRunnerFramesReady/markRunnerFramesReadyhandshake; per-file
reloadTestFileWithTimeout;enqueueHeadedReloadreplaces direct
rpcManager.reloadTestFilecalls; watch-mode rerun alsouses the queue
browser-ui/main.tsx— notifies host viaonRunnerFramesReadyonce framesare mounted; defers iframe
srctoabout:blankuntilrunIdis assigned;setActivecalled immediately on rerun triggerHostRPC/HostRpcMethods— newonRunnerFramesReadymethod added toboth the UI-side type and the host RPC handler