style(theme/sidebar): remove redundant first-child margin-top reset#3233
Merged
style(theme/sidebar): remove redundant first-child margin-top reset#3233
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the special-case styling that eliminated the top spacing on the first sidebar item, so all .rp-sidebar-item entries follow the same vertical spacing rules.
Changes:
- Deleted the
&:first-child { margin-top: 0; }override fromSidebarItem.scss.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff AnalysisFound 3 projects in monorepo, 1 project with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 webPath:
📦 Download Diff Report: web Bundle Diff Generated by Rsdoctor GitHub Action |
Deploying rspress-v2 with
|
| Latest commit: |
73275bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://58c463f9.rspress-v2.pages.dev |
| Branch Preview URL: | https://syt-vibe-kanban-647c-rp-side.rspress-v2.pages.dev |
Timeless0911
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
before
after
Related Issue
Checklist
AI Summary
Removed the redundant
&:first-child { margin-top: 0; }rule from.rp-sidebar-iteminSidebarItem.scss.The
.rp-sidebar-itemhas amargin-top: 2pxapplied to all items for spacing. The:first-childoverride tomargin-top: 0is unnecessary because the first sidebar item's top margin does not cause any visual issue — the parent container already handles its own padding/spacing. Removing this rule simplifies the stylesheet without affecting layout.This PR was written using Vibe Kanban