fix(core): Iterator#map is only available on Node 22+#2923
Merged
SoonIter merged 1 commit intoweb-infra-dev:mainfrom Dec 24, 2025
Merged
fix(core): Iterator#map is only available on Node 22+#2923SoonIter merged 1 commit intoweb-infra-dev:mainfrom
Iterator#map is only available on Node 22+#2923SoonIter merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Node.js version compatibility issue by replacing the use of Iterator#map (only available in Node 22+) with a standard array map method. The change ensures compatibility with the project's minimum Node.js version requirement of >=18.0.0.
Key Changes
- Converts
Set.values()to an array before callingmap()to avoid using the Node 22+ exclusiveIterator#mapmethod - Maintains identical functionality while supporting Node 18+
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@Timeless0911 How can I ensure that the output compiled by Rslib corresponds to my engines field? |
SoonIter
approved these changes
Dec 24, 2025
Iterator#map is only available on Node 22+Iterator#map is only available on Node 22+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Iterator#mapis only available on Node 22+ which is incompatible with rspress's baseline>=18.0.0Related Issue
N/A
Checklist