Skip to content

feat(theme): add text-autospace: normal;#2920

Merged
SoonIter merged 1 commit intomainfrom
syt/auto-space
Dec 22, 2025
Merged

feat(theme): add text-autospace: normal;#2920
SoonIter merged 1 commit intomainfrom
syt/auto-space

Conversation

@SoonIter
Copy link
Copy Markdown
Member

Summary

feat(theme): add text-autospace: normal;

Related Issue

https://x.com/yisibl/status/1979132340942041270

:root { text-autospace: normal; }

Benefits
Automatically adds an 1/8 em space between Chinese and English text.

Drawbacks

  • Performance degradation in certain scenarios.

  • The length of 1/8em isn't identical to a regular space.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 22, 2025 08:15
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 22, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 4589467
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/6948fe1532fc5a000816064e
😎 Deploy Preview https://deploy-preview-2920--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the text-autospace: normal CSS property to the :root selector to automatically add 1/8 em spacing between CJK (Chinese/Japanese/Korean) and non-CJK characters, improving typography for mixed-language content.

  • Adds text-autospace: normal to the :root selector in base.css
  • Includes explanatory comments about the property's purpose and how to override it
  • Acknowledges potential performance trade-offs in the PR description

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/core/src/theme/styles/base.css
Comment thread packages/core/src/theme/styles/base.css
@github-actions
Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 3 projects in monorepo, 1 project with changes.

📊 Quick Summary
Project Total Size Change
node_md 1.1 MB 0
web 15.0 MB +22.0 B (0.0%)
node 9.1 MB 0
📋 Detailed Reports (Click to expand)

📁 web

Path: website/doc_build/diff-rsdoctor/web/rsdoctor-data.json

📌 Baseline Commit: 1813c944fc | PR: #2918

Metric Current Baseline Change
📊 Total Size 15.0 MB 15.0 MB +22.0 B (0.0%)
📄 JavaScript 14.3 MB 14.3 MB 0
🎨 CSS 115.4 KB 115.4 KB +22.0 B (0.0%)
🌐 HTML 0 B 0 B 0
📁 Other Assets 516.6 KB 516.6 KB 0

📦 Download Diff Report: web Bundle Diff

Generated by Rsdoctor GitHub Action

@SoonIter SoonIter enabled auto-merge (squash) December 22, 2025 08:21
@SoonIter SoonIter merged commit 7ba7551 into main Dec 22, 2025
16 checks passed
@SoonIter SoonIter deleted the syt/auto-space branch December 22, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants