fix(theme/callout): link in callout should use currentColor#2838
Merged
Timeless0911 merged 2 commits intomainfrom Dec 3, 2025
Merged
fix(theme/callout): link in callout should use currentColor#2838Timeless0911 merged 2 commits intomainfrom
Timeless0911 merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes link styling in callouts to use currentColor instead of the brand color, ensuring links maintain visual consistency with their callout's theme color.
- Removed redundant link styles from callout component that were already defined in the global doc styles
- Updated hover border color to use
currentColorinstead of brand color for contextual theming
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/core/src/theme/components/Callout/index.scss |
Removed duplicate link styling (font-weight, transition, border-bottom) from callout content as these are already handled by the global .rp-link styles |
packages/core/src/theme/components/DocContent/doc.scss |
Changed link hover border from brand color to currentColor to respect the current text color context (e.g., callout theme colors) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff Analysis📁 webPath:
📦 Download Diff Report: web Bundle Diff Generated by Rsdoctor GitHub Action |
Timeless0911
approved these changes
Dec 3, 2025
This was referenced Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(theme/callout): link in callout should use currentColor
Related Issue
Checklist