fix(theme/Layout): render beforeNavMenu correctly#2822
Merged
SoonIter merged 1 commit intoweb-infra-dev:mainfrom Dec 29, 2025
Merged
fix(theme/Layout): render beforeNavMenu correctly#2822SoonIter merged 1 commit intoweb-infra-dev:mainfrom
beforeNavMenu correctly#2822SoonIter merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the rendering of the beforeNavMenu prop, which was previously not being passed from the Layout component to the Nav component, preventing it from being displayed.
- Added
beforeNavMenuto prop destructuring in Layout component - Passed
beforeNavMenuprop to Nav component - Repositioned
beforeNavMenurendering in Nav component to appear after the Search component
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/theme/layout/Layout/index.tsx | Added beforeNavMenu to destructuring and passed it to the Nav component to enable rendering |
| packages/core/src/theme/components/Nav/index.tsx | Moved beforeNavMenu rendering position to after the Search component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
SoonIter
reviewed
Nov 28, 2025
2 tasks
8313e33 to
4976b6d
Compare
Collaborator
Author
|
I've made minimal changes instead. @SoonIter |
beforeNavMenu correctlybeforeNavMenu correctly
This was referenced Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render
beforeNavMenucorrectlyRelated Issue
N/A
Checklist