fix(theme): table should be scrollable and startTransition should not be a html attribute#2792
Merged
fix(theme): table should be scrollable and startTransition should not be a html attribute#2792
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two issues: prevents the startTransition prop from being spread as an HTML attribute in the Link component, and makes tables horizontally scrollable on narrow screens with custom scrollbar styling.
- Refactored Link component to explicitly destructure and pass props instead of spreading all props to prevent non-HTML attributes from being passed to anchor elements
- Added horizontal scrolling support for tables with custom scrollbar styling
- Changed table body background from transparent to use a CSS variable
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/theme/components/Link/index.tsx | Extracted startTransition and other props from destructuring, then explicitly passed only valid HTML attributes to prevent React warnings about invalid DOM attributes |
| packages/core/src/theme/components/DocContent/doc.scss | Made tables scrollable with display: block and overflow: auto, added webkit scrollbar styling, and changed tbody background to use var(--rp-c-bg) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff Analysis📁 webPath:
📦 Download Diff Report: web Bundle Diff Generated by Rsdoctor GitHub Action |
bb414f0 to
3280fed
Compare
Timeless0911
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(theme): table should be scrollable and startTransition should not be a html attribute
Before
After
Related Issue
Checklist