fix(theme): h2 gap and twoslash codeblock style#2786
Merged
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes spacing issues in the theme by adjusting the h2 bottom margin and improving twoslash codeblock integration by removing conflicting styles.
- Reduced h2
margin-bottomfrom 2rem to 1.25rem to align with h3 spacing and improve visual consistency - Added a new
.twoslash .rp-codeblockselector to reset border, border-radius, box-shadow, and margins for better integration - Removed redundant
paddingandborder-radiusproperties from.twoslash .rp-codeblock__content
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/plugin-twoslash/static/global-styles/twoslash.css | Adds style resets for twoslash codeblocks to remove borders, shadows, and margins, and removes now-redundant padding and border-radius from the content element |
| packages/core/src/theme/components/DocContent/doc.scss | Reduces h2 bottom margin from 2rem to 1.25rem for better spacing consistency with h3, and adds a clarifying comment to the p element margin |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff Analysis📁 webPath:
📦 Download Diff Report: web Bundle Diff Generated by Rsdoctor GitHub Action |
Timeless0911
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(theme): h2 gap and twoslash codeblock style
Related Issue
Checklist