Skip to content

fix(theme): adjust line-height of sidebar and outline#2784

Merged
SoonIter merged 3 commits intomainfrom
syt/fix-line-height-sidebar
Nov 19, 2025
Merged

fix(theme): adjust line-height of sidebar and outline#2784
SoonIter merged 3 commits intomainfrom
syt/fix-line-height-sidebar

Conversation

@SoonIter
Copy link
Member

Summary

fix(theme): adjust line-height

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 18, 2025 13:17
@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 12a1e60
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/691d39a2b55212000813255a
😎 Deploy Preview https://deploy-preview-2784--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Rsdoctor Bundle Diff Analysis

📁 web

Path: website/doc_build/web/rsdoctor-data.json

Metric Current Baseline Change
📊 Total Size 14.3 MB 14.3 MB 27.0 B (0.0%)
📄 JavaScript 13.7 MB 13.7 MB 0 B (0.0%)
🎨 CSS 109.4 KB 109.4 KB 27.0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 496.7 KB 496.7 KB 0 B (0.0%)

📦 Download Diff Report: web Bundle Diff

Generated by Rsdoctor GitHub Action

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the line-height and spacing of sidebar and table of contents (outline) components to improve the visual layout and compactness.

  • Reduced line-height in both sidebar items (32px → 24px) and TOC items (24px → 20px)
  • Replaced gap-based spacing with margin-based spacing for TOC items
  • Increased vertical padding in sidebar items for better touch targets

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/core/src/theme/components/Toc/TocItem.scss Reduced line-height to 20px, added margin-based spacing between items, and refined the active state selector to target only code elements
packages/core/src/theme/components/Sidebar/SidebarItem.scss Reduced line-height to 24px and increased vertical padding from 2px to 6px
packages/core/src/theme/components/Outline/index.scss Removed gap property from TOC container (replaced by item-level margins)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SoonIter SoonIter requested review from Timeless0911 and removed request for Timeless0911 November 19, 2025 03:26
@SoonIter SoonIter force-pushed the syt/fix-line-height-sidebar branch from aa89432 to 12a1e60 Compare November 19, 2025 03:29
@SoonIter SoonIter enabled auto-merge (squash) November 19, 2025 03:42
@SoonIter SoonIter merged commit 6093b83 into main Nov 19, 2025
9 checks passed
@SoonIter SoonIter deleted the syt/fix-line-height-sidebar branch November 19, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants