Skip to content

fix(theme): unused code#2781

Merged
SoonIter merged 2 commits intomainfrom
syt/fix-scroll-2
Nov 19, 2025
Merged

fix(theme): unused code#2781
SoonIter merged 2 commits intomainfrom
syt/fix-scroll-2

Conversation

@SoonIter
Copy link
Member

Summary

fix: unused code

Related Issue

#2779

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 18, 2025 12:17
@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit e1eaea7
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/691c6530bf94b80008ffb85c
😎 Deploy Preview https://deploy-preview-2781--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes duplicate scroll-to-top logic from useScrollAfterNav that was already handled by the separate useScrollReset hook. The change simplifies the code by having useScrollAfterNav focus solely on scrolling to hash targets.

  • Removed redundant scroll-to-top behavior (already handled by useScrollReset)
  • Modified the effect dependency to use the full location object

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Rsdoctor Bundle Diff Analysis

📁 web

Path: website/doc_build/web/rsdoctor-data.json

Metric Current Baseline Change
📊 Total Size 14.3 MB 14.3 MB 8.3 KB (0.1%)
📄 JavaScript 13.7 MB 13.7 MB 8.3 KB (0.1%)
🎨 CSS 109.4 KB 109.4 KB 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 496.7 KB 496.7 KB 0 B (0.0%)

📦 Download Diff Report: web Bundle Diff

Generated by Rsdoctor GitHub Action

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SoonIter SoonIter merged commit dbc89d8 into main Nov 19, 2025
9 checks passed
@SoonIter SoonIter deleted the syt/fix-scroll-2 branch November 19, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants