fix(theme): Link click area should be same#2777
Merged
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the clickable area inconsistency in navigation and hover group components by ensuring links fill their parent containers completely. The changes standardize the clickable areas across different UI components.
- Added
height: 100%;to navigation menu items - Created a dedicated link wrapper class in HoverGroup with explicit height styling
- Restructured CSS to move clickable area styling to the link level
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/theme/components/Nav/NavMenu.scss | Added height: 100%; to nav menu items to fill the parent container |
| packages/core/src/theme/components/HoverGroup/index.tsx | Added rp-hover-group__item__link className to Link component for targeted styling |
| packages/core/src/theme/components/HoverGroup/index.scss | Removed item-level cursor styling and added link-specific height styling for consistent clickable area |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff Analysis📁 webPath:
Generated by Rsdoctor GitHub Action |
Timeless0911
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(theme): area should be same
The clickable area of the language switch region is too small, for example, when the mouse is placed slightly above "English", there is already a hover effect, but it cannot be clicked.
Related Issue
Checklist