fix(search): SearchPanel Enter keyboard not work regression#2775
Merged
fix(search): SearchPanel Enter keyboard not work regression#2775
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the Enter key wasn't working properly in the search panel due to incorrect usage of Object.values() on a Map object, and adds comprehensive e2e tests for keyboard navigation in search.
- Changed
Object.values()toArray.from().values()to correctly extract values from a Map object - Added e2e test suite covering keyboard navigation (ArrowUp/Down, Enter, Escape, Cmd+K/Ctrl+K)
- Created new test fixture for search functionality testing
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/theme/components/Search/SearchPanel.tsx | Fixed bug where Object.values() was incorrectly used on a Map object; changed to Array.from().values() to properly extract Map values |
| e2e/fixtures/search/index.test.ts | Added comprehensive e2e tests for keyboard navigation in search panel |
| e2e/fixtures/search/package.json | Added package configuration for the new search test fixture |
| e2e/fixtures/search/rspress.config.ts | Added rspress configuration for the search test fixture |
| e2e/fixtures/search/tsconfig.json | Added TypeScript configuration for the search test fixture |
| e2e/fixtures/search/doc/index.mdx | Added test content page for search testing |
| e2e/fixtures/search/doc/foo.mdx | Added test content page with "Foo" keyword for search testing |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff Analysis📁 webPath:
Generated by Rsdoctor GitHub Action |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Timeless0911
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(search): Enter keyboard should work
Related Issue
introduced in #2586
Checklist