fix(theme): button gradient color and add line-height back#2771
Merged
Timeless0911 merged 2 commits intomainfrom Nov 18, 2025
Merged
fix(theme): button gradient color and add line-height back#2771Timeless0911 merged 2 commits intomainfrom
Timeless0911 merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the gradient styling in the theme by extracting a hardcoded color value into a CSS variable and applies consistent styling. The changes improve maintainability by eliminating duplicate gradient definitions and add a line-height property to documentation content.
- Introduces a new CSS variable
--rp-home-hero-secondary-colorfor the gradient's secondary color (#a673ff) - Refactors the button component to reuse the existing gradient variable instead of duplicating the gradient definition
- Adds a base line-height of 1.75rem to documentation content
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/theme/styles/vars/home-vars.css | Introduces --rp-home-hero-secondary-color variable and uses it in the light mode gradient |
| packages/core/src/theme/components/Button/index.scss | Refactors to use --rp-home-hero-title-bg variable instead of duplicating gradient definition |
| packages/core/src/theme/components/DocContent/doc.scss | Adds base line-height of 1.75rem to documentation content |
Comments suppressed due to low confidence (1)
packages/core/src/theme/styles/vars/home-vars.css:46
- The dark mode gradient (line 46) still uses the hardcoded color
#a673ffinstead of the new--rp-home-hero-secondary-colorvariable. This creates inconsistency with the light mode implementation. Consider also defining--rp-home-hero-secondary-colorin the dark mode section or using the variable from light mode to maintain consistency.
#a673ff 100%
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
approved these changes
Nov 18, 2025
Contributor
Rsdoctor Bundle Diff Analysis📁 webPath:
Generated by Rsdoctor GitHub Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chore(theme): button gradient color and add doc.scss
Related Issue
Checklist