Merged
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the nprogress bar color by reordering CSS imports and refactoring style organization. The fix ensures that the nprogress library's default styles load first, allowing the custom brand color override to work correctly.
- Moved nprogress CSS import to load before custom styles, ensuring proper CSS cascade
- Increased CSS specificity for the color override using
:root #nprogress .bar - Refactored component-specific styles into a dedicated NavTitle.scss file for better organization
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/theme/styles/index.ts | Moved nprogress CSS import to the top to ensure library defaults load before custom overrides |
| packages/core/src/theme/styles/base.css | Updated nprogress bar selector with higher specificity and removed redundant positioning styles now provided by the library |
| packages/core/src/theme/components/Nav/index.scss | Removed logo and dark mode styles (moved to NavTitle.scss) |
| packages/core/src/theme/components/Nav/NavTitle.tsx | Added import for the new NavTitle.scss stylesheet |
| packages/core/src/theme/components/Nav/NavTitle.scss | Created new file containing logo and dark mode styles for better component colocation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
approved these changes
Nov 18, 2025
Contributor
Rsdoctor Bundle Diff Analysis📁 webPath:
Generated by Rsdoctor GitHub Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(theme): nprogress bar color
Related Issue
Checklist