feat(auto-nav-sidebar): add new type: "dir-section-header"#2643
Merged
feat(auto-nav-sidebar): add new type: "dir-section-header"#2643
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new sidebar item type called "dir-section-header" that combines directory and section header functionality in the auto-nav-sidebar feature.
- Introduces a new
DirSectionHeaderSideMetatype that merges directory and section header metadata - Adds processing logic for the new type in the normalization module
- Refactors existing code to support the new type and improve maintainability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/node/auto-nav-sidebar/type.ts | Defines the new DirSectionHeaderSideMeta type and adds it to the union type |
| packages/core/src/node/auto-nav-sidebar/normalize.ts | Implements processing logic for the new type and refactors existing functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Timeless0911
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat(auto-nav-sidebar): add new type: "section-header-dir"
For new UI:
Migrate
"type": "dir"to"type": "dir-section-header"before
[ { "type": "dir", "name": "use-mdx", "label": "Use MDX" }, ]after
[ { "type": "dir-section-header", "name": "use-mdx", "label": "Use MDX" // required field } ]Related Issue
Checklist