refactor: normalizeThemeConfig code style#2481
Merged
Timeless0911 merged 1 commit intomainfrom Aug 15, 2025
Merged
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the normalizeThemeConfig function by extracting common patterns into reusable helper functions and simplifying the navigation item transformation logic.
- Extracts text replacement and link transformation logic into dedicated helper functions
- Simplifies the navigation item transformation with a more generic recursive approach
- Removes redundant property spreading and removes the
tagproperty assignment
Comments suppressed due to low confidence (2)
packages/core/src/node/runtimeModule/siteData/normalizeThemeConfig.ts:107
- The removal of
tag: item.tagproperty assignment may be unintentional. If the tag property should be preserved in the normalized sidebar item, it needs to be included in the spread operation or explicitly assigned.
items: item.items.map(subItem => {
packages/core/src/node/runtimeModule/siteData/normalizeThemeConfig.ts:119
- The removal of
tag: item.tagproperty assignment may be unintentional. If the tag property should be preserved in the normalized sidebar item, it needs to be included in the new implementation.
};
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Timeless0911
previously approved these changes
Aug 15, 2025
Timeless0911
previously approved these changes
Aug 15, 2025
Timeless0911
previously approved these changes
Aug 15, 2025
63e32fa to
3070e5c
Compare
Timeless0911
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refactor: normalizeThemeConfig code style
Related Issue
Checklist