feat: enable rspack native watcher by default#2472
Merged
GiveMe-A-Name merged 3 commits intomainfrom Sep 2, 2025
Merged
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for rspress ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables rspack's native watcher by default while providing an environment variable override mechanism. The native watcher is expected to improve file watching performance compared to the default JavaScript-based watcher.
- Adds rspack experiments configuration to enable native watcher by default
- Provides
RSPRESS_NATIVE_WATCHERenvironment variable to disable the feature when needed
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a7f2fc0 to
5acb44b
Compare
chenjiahan
reviewed
Aug 15, 2025
auto-merge was automatically disabled
August 15, 2025 08:58
Pull request was converted to draft
chenjiahan
approved these changes
Aug 15, 2025
GiveMe-A-Name
commented
Aug 15, 2025
696d02e to
a9130c9
Compare
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
a9130c9 to
5974c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rspack native watcher pass all rspress e2e tests. We can enable rspack native watcher in rspress by default.
User can disable native watcher by setting RSPRESS_NATIVE_WATCHER as 'false' if we found any problems.
Related Issue
Checklist