refactor(runtime): split hooks into several files#2454
Merged
Conversation
✅ Deploy Preview for rspress ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the hooks in the runtime package by splitting them from a single monolithic file into separate, focused files. The refactoring also consolidates duplicated functionality across the theme-default package.
Key changes:
- Split runtime hooks from a single file into separate hook files for better organization
- Move sidebar and navigation utilities from theme-default to runtime for better reusability
- Update all import statements across the codebase to use the new hook structure
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/runtime/src/hooks.ts | Removed large monolithic hooks file |
| packages/runtime/src/hooks/*.ts | Added individual hook files (useDark, useFrontmatter, useI18n, etc.) |
| packages/runtime/src/hooks/useSidebar.ts | Moved sidebar logic from theme-default with getSidebarDataGroup function |
| packages/runtime/src/route.ts | Added isActive function moved from theme-default |
| packages/theme-default/src/**/*.ts | Updated imports to use new hook structure from runtime |
| packages/theme-default/src/logic/*.ts | Removed files that were moved to runtime |
| packages/shared/src/types/defaultTheme.ts | Moved SidebarData type definition and updated NormalizedSidebarGroup |
Timeless0911
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refactor(runtime): split hooks into several files
Related Issue
Checklist