fix(link): should support public folder asset#2440
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes support for public folder assets by updating the Link component to handle external URLs that don't match any routes. The fix ensures that when a link points to a public asset or external URL that doesn't have a matching route, it navigates using window.location.href instead of attempting route-based navigation.
- Adds fallback navigation for unmatched routes to support public folder assets
- Prevents route navigation attempts for external URLs and static assets
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for rspress ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Timeless0911
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: should support public folder asset
Related Issue
close #2427
Checklist