Skip to content

fix: children should be unavailable for CodeBlockRuntime#2205

Merged
SoonIter merged 1 commit intoweb-infra-dev:mainfrom
JounQin:fix/CodeBlockRuntime
May 26, 2025
Merged

fix: children should be unavailable for CodeBlockRuntime#2205
SoonIter merged 1 commit intoweb-infra-dev:mainfrom
JounQin:fix/CodeBlockRuntime

Conversation

@JounQin
Copy link
Copy Markdown
Collaborator

@JounQin JounQin commented May 26, 2025

Summary

image

Related Issue

related #2190

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify Bot commented May 26, 2025

Deploy Preview for rspress-v2 failed. Why did it fail? →

Name Link
🔨 Latest commit 03ddb0c
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/6834216afedbe70008f4f7f7

1 similar comment
@netlify
Copy link
Copy Markdown

netlify Bot commented May 26, 2025

Deploy Preview for rspress-v2 failed. Why did it fail? →

Name Link
🔨 Latest commit 03ddb0c
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/6834216afedbe70008f4f7f7

@SoonIter SoonIter merged commit 0233244 into web-infra-dev:main May 26, 2025
4 of 9 checks passed
@SoonIter
Copy link
Copy Markdown
Member

could title be optional?

And we also need a shikiOptions to pass shiki options

https://preview.fumadocs.dev/docs/ui/components/dynamic-codeblock

@JounQin JounQin deleted the fix/CodeBlockRuntime branch May 26, 2025 09:49
@JounQin
Copy link
Copy Markdown
Collaborator Author

JounQin commented May 26, 2025

could title be optional?

It's already optional.

And we also need a shikiOptions to pass shiki options

OK, I'll raise another PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants