Skip to content

fix: sidebar type=file with data-context#2189

Merged
SoonIter merged 6 commits intomainfrom
fix/sidebar-item-link-with-context
May 26, 2025
Merged

fix: sidebar type=file with data-context#2189
SoonIter merged 6 commits intomainfrom
fix/sidebar-item-link-with-context

Conversation

@zoolsher
Copy link
Copy Markdown
Member

@zoolsher zoolsher commented May 22, 2025 •
edited
Loading

Summary

The div.rspress-sidebar-item and the final Link component were initially implemented separately, causing certain cases to be overlooked, as shown in the test cases. Here's what I've done to address this issue:

  1. Unified the implementation of div.rspress-sidebar-item and Link components to prevent any oversights.
  2. Updated some test cases due to changes in the sidebar DOM structure.
  3. Added test cases that correspond to the reproduced issue.

Related Issue

issue:#2202

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify Bot commented May 22, 2025 •
edited
Loading

✅ Deploy Preview for rspress ready!

Name Link
🔨 Latest commit 2d74c98
🔍 Latest deploy log https://app.netlify.com/projects/rspress/deploys/6833d5c6ecc95f0008fa578a
😎 Deploy Preview https://deploy-preview-2189--rspress.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 77 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 22, 2025 •
edited
Loading

✅ Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 2d74c98
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/6833d5c61885ce000815cf9b
😎 Deploy Preview https://deploy-preview-2189--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zoolsher zoolsher requested a review from Timeless0911 May 24, 2025 15:07
@zoolsher zoolsher force-pushed the fix/sidebar-item-link-with-context branch from 4162846 to 8152046 Compare May 26, 2025 02:41
@JounQin
Copy link
Copy Markdown
Collaborator

JounQin commented May 26, 2025 •
edited
Loading

Can you please open an issue/discussion first to describe what are you trying to resolve? I have no idea what you're doing, no summary, no related issue nor reference.

@zoolsher
Copy link
Copy Markdown
Member Author

zoolsher commented May 26, 2025

Can you please open an issue/discussion first to describe what are you trying to resolve? I have no idea what you're doing, no summary, no related issue or reference.

Certainly! I've created an issue and updated the summary for this pull request.

@SoonIter SoonIter merged commit 3b13ac7 into main May 26, 2025
12 checks passed
@SoonIter SoonIter deleted the fix/sidebar-item-link-with-context branch May 26, 2025 03:30
@SoonIter SoonIter mentioned this pull request May 26, 2025
Closed
@SoonIter
Copy link
Copy Markdown
Member

SoonIter commented May 26, 2025

thanks ❤~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SoonIter SoonIter SoonIter approved these changes

@Timeless0911 Timeless0911 Awaiting requested review from Timeless0911

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zoolsher @JounQin @SoonIter