feat(ssg): add printFileSize to SSG, and refactor renderPages to a rsbuildPluginSSG#2065
Merged
feat(ssg): add printFileSize to SSG, and refactor renderPages to a rsbuildPluginSSG#2065
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
75cb202 to
b630573
Compare
8e209a2 to
987bd08
Compare
b495b78 to
c411162
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
e2e/utils/runCommands.ts:51
- The updated regex for the 'build' command output may not reliably match the intended success marker across environments. Consider verifying that this pattern consistently detects a successful build or updating it to a more specific pattern.
build: /File (web)/,
Co-authored-by: Timeless0911 <50201324+Timeless0911@users.noreply.github.com>
Timeless0911
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refactor renderPages to a rsbuildPluginSSG
benefits
add printFileSize to SSG
build within rsbuild lifecycle, can be uploaded by rsbuild-plugin-deploy, such as zephyr
drawbacks
Build time now includes the renderPage time. So the value will be larger than before, but it is acceptable.
Related Issue
Checklist