refactor: change setup into useSetup hook for reactive scrollPaddingTop#2027
Merged
SoonIter merged 2 commits intoweb-infra-dev:mainfrom Apr 1, 2025
Merged
refactor: change setup into useSetup hook for reactive scrollPaddingTop#2027SoonIter merged 2 commits intoweb-infra-dev:mainfrom
setup into useSetup hook for reactive scrollPaddingTop#2027SoonIter merged 2 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2703e2c to
f0ec116
Compare
SoonIter
reviewed
Apr 1, 2025
SoonIter
reviewed
Apr 1, 2025
SoonIter
reviewed
Apr 1, 2025
SoonIter
previously approved these changes
Apr 1, 2025
Member
SoonIter
left a comment
There was a problem hiding this comment.
LGTM, i'll fix "#theme" in other pr
JounQin
commented
Apr 1, 2025
Collaborator
Author
@SoonIter 😂 Oh, I just changed them, and so that it can be cherry picked easier into |
c76a9e3 to
de9f562
Compare
de9f562 to
989b463
Compare
SoonIter
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
related #1540 (comment)
cc @SoonIter @Timeless0911
Checklist
Not sure whether should and how to add related test cases.