Skip to content

docs: update lastUpdated need commit#1845

Merged
Timeless0911 merged 3 commits intoweb-infra-dev:mainfrom
markH5:need_git_doc
Feb 13, 2025
Merged

docs: update lastUpdated need commit#1845
Timeless0911 merged 3 commits intoweb-infra-dev:mainfrom
markH5:need_git_doc

Conversation

@markH5
Copy link
Copy Markdown
Contributor

@markH5 markH5 commented Feb 13, 2025

Summary

Related Issue

Initially, I assumed the feature relied on the file's mtime. However, I observed that mtime wasn't consistently updated after file modifications. While the upload time derived from git appears reasonable, I recommend documenting this behavior for clarity.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 13, 2025 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 1a14d9a
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67ad9292844a8d0008ab40f5
😎 Deploy Preview https://deploy-preview-1845--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 81 (🟢 up 17 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911
Copy link
Copy Markdown
Contributor

Timeless0911 commented Feb 13, 2025

I think we just need to add a tip container above packages/document/docs/en/plugin/official-plugins/last-updated.mdx which can be:

:::tip
You need to commit the markdown file to see the updated time.
:::

ref: https://vitepress.dev/reference/default-theme-last-updated#last-updated

@markH5
Copy link
Copy Markdown
Contributor Author

markH5 commented Feb 13, 2025

Feel free to make direct edits to the pull request.

@Timeless0911 Timeless0911 enabled auto-merge (squash) February 13, 2025 06:36
@Timeless0911 Timeless0911 enabled auto-merge (squash) February 13, 2025 06:36
@Timeless0911 Timeless0911 changed the title docs: update lastUpdated need git docs: update lastUpdated need commit Feb 13, 2025
@Timeless0911 Timeless0911 merged commit 97e3e03 into web-infra-dev:main Feb 13, 2025
8 checks passed
@markH5 markH5 deleted the need_git_doc branch March 18, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees

No one assigned

Labels

change: docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markH5 @Timeless0911