fix(runtime): determine virtual routes by config file#1829
Merged
SoonIter merged 1 commit intoweb-infra-dev:mainfrom Feb 10, 2025
Merged
fix(runtime): determine virtual routes by config file#1829SoonIter merged 1 commit intoweb-infra-dev:mainfrom
SoonIter merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SoonIter
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Previously,
virtual-routesandvirtual-routes-ssrwill be bundled in either SSR and non SSR, which will make the routes be eager imported by SSR, although routes are dynamic imported in non SSR.In this PR, determine the correct module ID as we already know it when initiating the config, which could also remove
requirefrom ESM code.Related Issue
Checklist