refactor(theme): new sidebar match algorithm and export SidebarList UI only component#1780
Merged
refactor(theme): new sidebar match algorithm and export SidebarList UI only component#1780
SidebarList UI only component#1780Conversation
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cb8422f to
19ab890
Compare
SidebarList UI only component
Timeless0911
approved these changes
Feb 7, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
1. refactor sidebar
matchPathalgorithm, the old one is too hard to understandnow
assumes that user's sidebar is as below
the route which hits
matchPath("/guide/", currentPathname)/guide/*would be showne.g: under
'/guide/quick-start.html'would show thesidebar["/guide"]before
if route hits one item in this config
e.g:
"/guide/quick-start/index.html"hits{"text": "快速上手", "link": "/guide/quick-start" }and
sidebar["/guide"]would be shownIn fact, the new algorithm will be more fast in performance, and I think there aren't cases that's not be covered
2. extract
SidebarListUI only component for better maintainability and someone wants to customize sidebar UI