Skip to content

fix(plugin-preview): should use correct default previewMode#1715

Merged
Timeless0911 merged 1 commit intomainfrom
fix/default-preview-mode
Dec 27, 2024
Merged

fix(plugin-preview): should use correct default previewMode#1715
Timeless0911 merged 1 commit intomainfrom
fix/default-preview-mode

Conversation

@Timeless0911
Copy link
Copy Markdown
Contributor

Summary

Should use correct default previewMode.

isMobile should be removed in Rspress 2.0

Related Issue

closes: #1714

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 changed the title fix: should use correct default previewMode fix(plugin-preview): should use correct default previewMode Dec 27, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 27, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit e57e59b
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/676e3f434770bb0008cab559
😎 Deploy Preview https://deploy-preview-1715--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🟢 up 18 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 enabled auto-merge (squash) December 27, 2024 05:47
@Timeless0911 Timeless0911 merged commit e853b4e into main Dec 27, 2024
@Timeless0911 Timeless0911 deleted the fix/default-preview-mode branch December 27, 2024 06:15
@SoonIter
Copy link
Copy Markdown
Member

can not image how the tests added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The internal value of previewMode option of @rspress/plugin-preview plugin does not work

2 participants