fix: close hamburger menu when click on item on mobile#1712
Merged
Timeless0911 merged 2 commits intoweb-infra-dev:mainfrom Dec 26, 2024
coratgerl:fix-close-navbar-when-click-item
Merged
fix: close hamburger menu when click on item on mobile#1712Timeless0911 merged 2 commits intoweb-infra-dev:mainfrom coratgerl:fix-close-navbar-when-click-item
Timeless0911 merged 2 commits intoweb-infra-dev:mainfrom
coratgerl:fix-close-navbar-when-click-item
Conversation
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
LGTM after adopting the suggestions |
Contributor
Author
|
Done ! Thanks for your feedbacks ! |
Timeless0911
approved these changes
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When we click on an item in an hamburger menu, we should close the menu after click event.
Related Issue
Fixes: #1711
Checklist