perf: remove node-fetch polyfill#1662
Merged
Timeless0911 merged 1 commit intomainfrom Dec 15, 2024
Merged
Conversation
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Timeless0911
approved these changes
Dec 15, 2024
Merged
Member
|
it seems that it is not a correct passing-shabang-option way https://app.netlify.com/sites/rspack/deploys/676b3fe3df52430008077d47 
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove node-fetch polyfill to reduce 7.45MB install size:
fetchis builtin and enabled by default.fetchcan be enabled by the--experimental-fetchflag, I have updated thebinfile to enable it.Other Change
This PR also removed
mdast-util-mdxjs-esmfrom two packages because they never use it:TODO
I think the remote search should be redesigned in Rspress 2.0 as it is now a ByteDance SCM only feature.
See:
rspress/packages/core/src/node/searchIndex.ts
Line 42 in a373b32
Checklist