feat: support replacement nav title#1511
Merged
Timeless0911 merged 3 commits intoweb-infra-dev:mainfrom Oct 21, 2024
Merged
Conversation
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
LGTM for the pc devices, but when we use mobile devices, sidebar component will use rspress/packages/theme-default/src/components/Sidebar/index.tsx Lines 209 to 213 in 7caec92 You should also handle this scenario in an elegant way. |
Contributor
Author
Sorry, I missed it, I will add it later. |
Contributor
Author
|
updated 9eb7c01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Closes #1508
Related Issue
Checklist