Skip to content

feat: support replacement nav title#1511

Merged
Timeless0911 merged 3 commits intoweb-infra-dev:mainfrom
Yukiniro:usgkwa4p
Oct 21, 2024
Merged

feat: support replacement nav title#1511
Timeless0911 merged 3 commits intoweb-infra-dev:mainfrom
Yukiniro:usgkwa4p

Conversation

@Yukiniro
Copy link
Copy Markdown
Contributor

Summary

Closes #1508

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 21, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 9eb7c01
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67162674d39a8400084cb1f2
😎 Deploy Preview https://deploy-preview-1511--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911
Copy link
Copy Markdown
Contributor

LGTM for the pc devices, but when we use mobile devices, sidebar component will use < NavBarTitle /> component too.

{!uiSwitch.showNavbar ? null : (
<div className={styles.navTitleMask}>
<NavBarTitle />
</div>
)}

image

You should also handle this scenario in an elegant way.

@Yukiniro
Copy link
Copy Markdown
Contributor Author

LGTM for the pc devices, but when we use mobile devices, sidebar component will use < NavBarTitle /> component too.

{!uiSwitch.showNavbar ? null : (
<div className={styles.navTitleMask}>
<NavBarTitle />
</div>
)}

image

You should also handle this scenario in an elegant way.

Sorry, I missed it, I will add it later.

@Yukiniro
Copy link
Copy Markdown
Contributor Author

updated 9eb7c01

Copy link
Copy Markdown
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Timeless0911 Timeless0911 merged commit 2028a38 into web-infra-dev:main Oct 21, 2024
@Yukiniro Yukiniro deleted the usgkwa4p branch October 21, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Make nav title replaceable

2 participants