Skip to content

test: remove new code splitting tests as now its the default#9939

Merged
JSerFeng merged 1 commit intomainfrom
tests/remove-useless-tests
May 8, 2025
Merged

test: remove new code splitting tests as now its the default#9939
JSerFeng merged 1 commit intomainfrom
tests/remove-useless-tests

Conversation

@JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Apr 8, 2025

Summary

We make newCodeSplitting test which enables experiments.parallelCodeSplitting and runs all config/stats tests, now its true by default, all tests are already using experiments.parallelCodeSplitting, we don't need these tests anymore

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 8, 2025
@netlify
Copy link

netlify bot commented Apr 8, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 818b5df
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/681c5105dd511c000825ca0b

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 8, 2025

CodSpeed Performance Report

Merging #9939 will not alter performance

Comparing tests/remove-useless-tests (818b5df) with main (e7ab6e3)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@hardfist
Copy link
Contributor

hardfist commented Apr 8, 2025

so are tests still running for old splitting?

@JSerFeng
Copy link
Contributor Author

JSerFeng commented Apr 8, 2025

so are tests still running for old splitting?

No

@JSerFeng JSerFeng enabled auto-merge (squash) April 8, 2025 08:02
@JSerFeng JSerFeng marked this pull request as draft April 8, 2025 10:34
auto-merge was automatically disabled April 8, 2025 10:34

Pull request was converted to draft

@JSerFeng JSerFeng force-pushed the tests/remove-useless-tests branch 2 times, most recently from 9fc87c0 to 18a19d4 Compare May 8, 2025 03:53
@JSerFeng JSerFeng force-pushed the tests/remove-useless-tests branch from 18a19d4 to 818b5df Compare May 8, 2025 06:36
@JSerFeng JSerFeng marked this pull request as ready for review May 8, 2025 07:03
@JSerFeng JSerFeng merged commit c6d2d62 into main May 8, 2025
35 checks passed
@JSerFeng JSerFeng deleted the tests/remove-useless-tests branch May 8, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants