Skip to content

perf: remove useless iterator in new code splitting and some allocations#9821

Merged
JSerFeng merged 1 commit intomainfrom
perf/new-code-splitting
Mar 28, 2025
Merged

perf: remove useless iterator in new code splitting and some allocations#9821
JSerFeng merged 1 commit intomainfrom
perf/new-code-splitting

Conversation

@JSerFeng
Copy link
Contributor

Summary

Fix useless iterator and reduce some small allocations.

eg.

change

for i in 0..100 { 
  let mut v = vec![];
}

to

let mut v = vec![];

for i in 0..100 { 
  v.clear()
}

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@JSerFeng JSerFeng marked this pull request as ready for review March 28, 2025 06:27
@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 28, 2025
@netlify
Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8d3ea32
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67e6415cb423440008e944ef

@JSerFeng JSerFeng changed the title perf: fix useless iterator in new code splitting perf: remove useless iterator in new code splitting Mar 28, 2025
@JSerFeng JSerFeng changed the title perf: remove useless iterator in new code splitting perf: remove useless iterator in new code splitting and some allocations Mar 28, 2025
@JSerFeng JSerFeng enabled auto-merge (squash) March 28, 2025 06:38
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 28, 2025

CodSpeed Performance Report

Merging #9821 will not alter performance

Comparing perf/new-code-splitting (8d3ea32) with main (f61c7ab)

Summary

✅ 8 untouched benchmarks

@JSerFeng JSerFeng merged commit 5e95aaa into main Mar 28, 2025
39 checks passed
@JSerFeng JSerFeng deleted the perf/new-code-splitting branch March 28, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants