Skip to content

feat: support alias false#9809

Merged
ahabhgk merged 2 commits intomainfrom
fix-alias-false
Mar 28, 2025
Merged

feat: support alias false#9809
ahabhgk merged 2 commits intomainfrom
fix-alias-false

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Mar 26, 2025

Summary

webpack supports object and array for alias, the difference is object will merge with the default resolve options alias but array will overwrite the default resolve options alias, unless there is "...", and undefined is equal to {}, false is equal to [].

I've never seen a requirement that needs to support array, so for now I only support false here for simplicity.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 26, 2025
@netlify
Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit cb11e6c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67e64d9523613f00085ad5b4

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 26, 2025

CodSpeed Performance Report

Merging #9809 will not alter performance

Comparing fix-alias-false (cb11e6c) with main (5e95aaa)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 8 untouched benchmarks

@ahabhgk ahabhgk requested a review from SyMind March 28, 2025 07:26
@ahabhgk ahabhgk merged commit 0159e77 into main Mar 28, 2025
33 checks passed
@ahabhgk ahabhgk deleted the fix-alias-false branch March 28, 2025 07:43
colinaaa added a commit to lynx-family/lynx-stack that referenced this pull request Mar 29, 2025
Rspack supports `config.resolve.alias` to be `false` in 1.3.0.

See: web-infra-dev/rspack#9809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants