fix(rspack_plugin_mf): Track all referenced chunks#9707
Merged
Conversation
…t-dir # Conflicts: # crates/rspack_plugin_mf/src/container/module_federation_runtime_plugin.rs
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #9707 will not alter performanceComparing 🎉 Hooray!
|
ahabhgk
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track initial chunks (entry point chunks) in the chunk mapping for remotes and consumes as well.
This is a prerequisite to be able to support async startup and remove needed
import()at top of file.In webpack, we track all referenced chunks for single runtime chunk and multi entry based apps. Apps like next.js require us to track initial chunks so we can resolve entry requirements ahead of time without needing a import() to make the app run.
This does not implement asyncStartup runtime code, but does allow us to access the correct chunk maps as needed.
Checklist