Skip to content

fix: compiler js object cannot be gc#9685

Merged
SyMind merged 12 commits intomainfrom
fix-js-object-gc
Apr 27, 2025
Merged

fix: compiler js object cannot be gc#9685
SyMind merged 12 commits intomainfrom
fix-js-object-gc

Conversation

@SyMind
Copy link
Member

@SyMind SyMind commented Mar 14, 2025 •
edited
Loading

Summary

Compiler is unable to GC due to some ThreadsafeFunctions, which include

  1. hooks callback
  2. run_loaders

The solution is to strictly drop these ThreadsafeFunctions at the end of the build.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 14, 2025
@netlify
Copy link

netlify bot commented Mar 14, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bf71d2a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/680ddacdda774700080b3030

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9685 will not alter performance

Comparing fix-js-object-gc (bf71d2a) with main (b8c8945)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@SyMind SyMind force-pushed the fix-js-object-gc branch from 45f0c62 to 7d5470e Compare March 17, 2025 04:20
@SyMind SyMind closed this Apr 10, 2025
@SyMind SyMind deleted the fix-js-object-gc branch April 16, 2025 02:28
@SyMind SyMind restored the fix-js-object-gc branch April 25, 2025 08:16
@SyMind SyMind reopened this Apr 25, 2025
@SyMind SyMind force-pushed the fix-js-object-gc branch from accb2f2 to ce670c6 Compare April 27, 2025 01:42
@SyMind SyMind force-pushed the fix-js-object-gc branch from bbffab0 to c2dc22c Compare April 27, 2025 03:08
@SyMind SyMind force-pushed the fix-js-object-gc branch from c2dc22c to a6395c8 Compare April 27, 2025 04:08
quininer
quininer requested changes Apr 27, 2025
View reviewed changes
@SyMind SyMind marked this pull request as ready for review April 27, 2025 06:30
quininer
quininer reviewed Apr 27, 2025
View reviewed changes
quininer
quininer reviewed Apr 27, 2025
View reviewed changes
@SyMind SyMind force-pushed the fix-js-object-gc branch from 5e0f1c5 to 88cbe3c Compare April 27, 2025 06:34
@SyMind SyMind merged commit d71a6ab into main Apr 27, 2025
34 checks passed
@SyMind SyMind deleted the fix-js-object-gc branch April 27, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quininer quininer quininer approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SyMind @quininer