Skip to content

feat: externals getResolve callback third argument#9681

Merged
ahabhgk merged 2 commits intomainfrom
fix-get-resolve-callback
Mar 17, 2025
Merged

feat: externals getResolve callback third argument#9681
ahabhgk merged 2 commits intomainfrom
fix-get-resolve-callback

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Mar 14, 2025

Summary

Support externals getResolve callback third argument, checkout added test for usage

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from SyMind March 14, 2025 10:14
@netlify
Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit d861413
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67d7b44a3069090008e5ab02
😎 Deploy Preview https://deploy-preview-9681--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SyMind
SyMind previously approved these changes Mar 14, 2025
@ahabhgk ahabhgk enabled auto-merge (squash) March 14, 2025 10:19
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Mar 14, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 14, 2025

CodSpeed Performance Report

Merging #9681 will not alter performance

Comparing fix-get-resolve-callback (d861413) with main (6dbba54)

Summary

✅ 8 untouched benchmarks

@ahabhgk ahabhgk force-pushed the fix-get-resolve-callback branch from 307cd01 to 0058b17 Compare March 15, 2025 04:48
@ahabhgk ahabhgk requested a review from SyMind March 15, 2025 04:48
SyMind
SyMind previously approved these changes Mar 17, 2025
@ahabhgk ahabhgk force-pushed the fix-get-resolve-callback branch from 0058b17 to d861413 Compare March 17, 2025 05:34
@ahabhgk ahabhgk requested a review from SyMind March 17, 2025 05:38
@ahabhgk ahabhgk merged commit a9c9b35 into main Mar 17, 2025
31 checks passed
@ahabhgk ahabhgk deleted the fix-get-resolve-callback branch March 17, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants