Skip to content

feat: incremental for new code splitting#9667

Merged
JSerFeng merged 1 commit intomainfrom
fix/code-splitting-remove-parent-modules
Mar 14, 2025
Merged

feat: incremental for new code splitting#9667
JSerFeng merged 1 commit intomainfrom
fix/code-splitting-remove-parent-modules

Conversation

@JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Mar 13, 2025

Summary

CodeSplitting reuses some calculate result from previous build.

The new code splitting steps are as following:

  1. Analyze blocks to find all chunk entry
  2. Find chunk modules in parallel
  3. Find chunk's parents and children based on incoming blocks and outgoing blocks
  4. Remove modules in chunk which are already present in the parent chunks
  5. Create chunk and chunk group, connect chunk and module

We can cache results from step 1, step 2 and reuse some chunk in step 5, so next stages in seal can get information about which chunk has changed

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 13, 2025
@netlify
Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f86755a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67d3c316d62b020008f907aa

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2025

CodSpeed Performance Report

Merging #9667 will not alter performance

Comparing fix/code-splitting-remove-parent-modules (f86755a) with main (a1929a2)

Summary

✅ 8 untouched benchmarks

@JSerFeng JSerFeng force-pushed the fix/code-splitting-remove-parent-modules branch from 1dfddfd to f86755a Compare March 14, 2025 05:48
@JSerFeng JSerFeng marked this pull request as ready for review March 14, 2025 06:31
@JSerFeng JSerFeng merged commit b309d50 into main Mar 14, 2025
60 of 61 checks passed
@JSerFeng JSerFeng deleted the fix/code-splitting-remove-parent-modules branch March 14, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants