Skip to content

fix: define with recursion value#9646

Merged
ahabhgk merged 3 commits intomainfrom
fix-define-recursive
Mar 12, 2025
Merged

fix: define with recursion value#9646
ahabhgk merged 3 commits intomainfrom
fix-define-recursive

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Mar 12, 2025

Summary

Avoid endless recursion, for example: new DefinePlugin({ "typeof a": "typeof a" })

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from h-a-n-a March 12, 2025 09:24
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 12, 2025
@netlify
Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit de1d319
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67d169e076499000084838c8

@ahabhgk ahabhgk enabled auto-merge (squash) March 12, 2025 09:24
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #9646 will not alter performance

Comparing fix-define-recursive (de1d319) with main (a79e3c0)

Summary

✅ 8 untouched benchmarks

@ahabhgk ahabhgk merged commit 170a35a into main Mar 12, 2025
31 checks passed
@ahabhgk ahabhgk deleted the fix-define-recursive branch March 12, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants