Skip to content

feat(compiler-builder)!: support BuilderError#9627

Merged
h-a-n-a merged 3 commits intomainfrom
builder-error
Mar 12, 2025
Merged

feat(compiler-builder)!: support BuilderError#9627
h-a-n-a merged 3 commits intomainfrom
builder-error

Conversation

@h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Mar 11, 2025 •
edited
Loading

Summary

Closing #9379

Support printing BuilderError and remove panics.

CompilerBuilder::build now returns rspack_error::Result<Compiler> (previously, Compiler).

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Mar 11, 2025
@netlify
Copy link

netlify bot commented Mar 11, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f1a46f1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67d01e6d0a5c3c000845bd8c

@h-a-n-a h-a-n-a requested a review from chenjiahan March 11, 2025 10:53
@h-a-n-a h-a-n-a changed the title feat(compiler-builder): support BuilderError feat(compiler-builder)!: support BuilderError Mar 11, 2025
@h-a-n-a h-a-n-a added the release: breaking change release: breaking change related release(mr only) label Mar 11, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9627 will not alter performance

Comparing builder-error (f1a46f1) with main (eea429a)

Summary

✅ 8 untouched benchmarks

@h-a-n-a h-a-n-a enabled auto-merge (squash) March 11, 2025 11:59
@h-a-n-a h-a-n-a requested a review from jerrykingxyz March 11, 2025 11:59
@h-a-n-a h-a-n-a merged commit aabc042 into main Mar 12, 2025
31 checks passed
@h-a-n-a h-a-n-a deleted the builder-error branch March 12, 2025 02:37
@chenjiahan
Copy link
Member

chenjiahan commented Mar 12, 2025

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

Assignees

No one assigned

Labels

release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h-a-n-a @chenjiahan