Skip to content

fix(rspack_plugin_runtime): do not render chunks that only contain non-js module types#9521

Merged
ahabhgk merged 3 commits intomainfrom
fix/skip-virtual-chunk
Mar 3, 2025
Merged

fix(rspack_plugin_runtime): do not render chunks that only contain non-js module types#9521
ahabhgk merged 3 commits intomainfrom
fix/skip-virtual-chunk

Conversation

@ScriptedAlchemy
Copy link
Contributor

@ScriptedAlchemy ScriptedAlchemy commented Mar 1, 2025

Summary

Skip rendering chunks that do not exist / do not contain Module Type: 'javascript'

This prevents rendering virtual chunks like provide, share-init etc from module federation.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 1, 2025
@netlify
Copy link

netlify bot commented Mar 1, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f3f6e5f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67c2b66f4206550008cd8c00

@chenjiahan chenjiahan requested a review from ahabhgk March 1, 2025 05:38
@ScriptedAlchemy ScriptedAlchemy changed the title fix(rspack_plugin_runtime): do not render empty chunks into entry sta… fix(rspack_plugin_runtime): do not render chunks that only contain non-js module types Mar 1, 2025
@ScriptedAlchemy ScriptedAlchemy force-pushed the fix/skip-virtual-chunk branch from dac523e to f3f6e5f Compare March 1, 2025 07:25
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 1, 2025

CodSpeed Performance Report

Merging #9521 will not alter performance

Comparing fix/skip-virtual-chunk (f3f6e5f) with main (25661fe)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@ahabhgk ahabhgk merged commit 42ce515 into main Mar 3, 2025
27 checks passed
@ahabhgk ahabhgk deleted the fix/skip-virtual-chunk branch March 3, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Module Federation ESM output attempts to import virtual chunk ids

2 participants