Skip to content

fix: rebuild ignore modules contain built-in loader errors#9482

Merged
jerrykingxyz merged 2 commits intomainfrom
jerry/make
Feb 27, 2025
Merged

fix: rebuild ignore modules contain built-in loader errors#9482
jerrykingxyz merged 2 commits intomainfrom
jerry/make

Conversation

@jerrykingxyz
Copy link
Contributor

@jerrykingxyz jerrykingxyz commented Feb 26, 2025

Summary

Builtin loaders throw error will make normal module does not contains any file_dependencies and mark as cacheable, those modules will never rebuild forever with memory cache. This PR will mark those module as cacheable and set they resourcePath as file_dependencies.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 26, 2025
@netlify
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c34e4e6
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bfec5a0edb2a0008687dfd

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #9482 will not alter performance

Comparing jerry/make (c34e4e6) with main (3a60a03)

Summary

✅ 7 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants