fix: use persistent cache with module federation#9445
Merged
jerrykingxyz merged 1 commit intomainfrom Feb 25, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #9445 will not alter performanceComparing Summary
|
ahabhgk
approved these changes
Feb 25, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Module federation plugin collects the consumption location and use
compilation.add_includesto generate them as entry, but the plugin state cannot be saved to the persistent cache, which will cause bug when hot start.https://github.com/web-infra-dev/rspack/blob/main/crates/rspack_plugin_mf/src/sharing/provide_shared_plugin.rs#L85
This PR will make the ConsumeSharedModule non-cacheable so that it is always regenerated on hot start to restore plugin state.
Checklist