Skip to content

fix: update CLI flags to use camelCase consistently#9442

Merged
chenjiahan merged 1 commit intomainfrom
cli_flag_casing_0224
Feb 24, 2025
Merged

fix: update CLI flags to use camelCase consistently#9442
chenjiahan merged 1 commit intomainfrom
cli_flag_casing_0224

Conversation

@chenjiahan
Copy link
Member

Summary

This PR updates the Rspack CLI flags to use camelCase consistently.

The yargs package will convert camelCase to kebab-case, so both the two cases are supported:

Screenshot 2025-02-24 at 16 57 50

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Feb 24, 2025
@netlify
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit d936031
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bc3b94f1f67f00083af421
😎 Deploy Preview https://deploy-preview-9442--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan requested a review from 9aoy February 24, 2025 09:43
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #9442 will not alter performance

Comparing cli_flag_casing_0224 (d936031) with main (121557a)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@chenjiahan chenjiahan merged commit 80d8625 into main Feb 24, 2025
31 checks passed
@chenjiahan chenjiahan deleted the cli_flag_casing_0224 branch February 24, 2025 10:01
@h-a-n-a h-a-n-a mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants