Skip to content

test: remove hash test in sri plugin cases#9440

Merged
LingyuCoder merged 1 commit intomainfrom
test/sri-hash-case
Feb 24, 2025
Merged

test: remove hash test in sri plugin cases#9440
LingyuCoder merged 1 commit intomainfrom
test/sri-hash-case

Conversation

@LingyuCoder
Copy link
Contributor

Summary

This pull request includes changes to the webpack.config.js file in the tests/plugin-test/sri-plugin/examples/issue-152 directory. The changes focus on modifying the output filename configuration and updating the test expectations for the generated assets.

Changes to output filename configuration:

  • Modified the filename property in the output configuration from using [contenthash].js to [name].js.

Updates to test expectations:

  • Changed the test to check for the presence of main.js and verify its content instead of checking for a specific hashed filename. The new expectation checks that main.js contains a specific JSON string.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 24, 2025
@netlify
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 22645db
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bc13c65bdebd000830c395

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #9440 will not alter performance

Comparing test/sri-hash-case (22645db) with main (e8b77c4)

Summary

✅ 7 untouched benchmarks

@LingyuCoder LingyuCoder enabled auto-merge (squash) February 24, 2025 08:03
@LingyuCoder LingyuCoder requested a review from SyMind February 24, 2025 10:50
@LingyuCoder LingyuCoder merged commit cf4d882 into main Feb 24, 2025
31 checks passed
@LingyuCoder LingyuCoder deleted the test/sri-hash-case branch February 24, 2025 10:51
@h-a-n-a h-a-n-a mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants