Skip to content

fix: hmr should work when moving module between different runtime#9412

Merged
ahabhgk merged 10 commits intomainfrom
move-module-between-runtime
Feb 25, 2025
Merged

fix: hmr should work when moving module between different runtime#9412
ahabhgk merged 10 commits intomainfrom
move-module-between-runtime

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Feb 20, 2025

Summary

hmr should work when moving module between different runtime

related: #5597

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Feb 20, 2025
@netlify
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit d10ff9c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bd7d64f1c14f0008d1e99c

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9412 will improve performances by 6.1%

Comparing move-module-between-runtime (d10ff9c) with main (fd867cf)

Summary

⚡ 1 improvements
✅ 6 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
build_chunk_graph_parallel 72.2 ms 68.1 ms +6.1%

@ahabhgk ahabhgk marked this pull request as ready for review February 25, 2025 05:16
@ahabhgk ahabhgk requested a review from LingyuCoder February 25, 2025 05:16
@ahabhgk ahabhgk enabled auto-merge (squash) February 25, 2025 05:30
LingyuCoder
LingyuCoder previously approved these changes Feb 25, 2025
@ahabhgk ahabhgk requested a review from LingyuCoder February 25, 2025 07:12
@ahabhgk ahabhgk merged commit 836b4a1 into main Feb 25, 2025
27 checks passed
@ahabhgk ahabhgk deleted the move-module-between-runtime branch February 25, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants